Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebook execution #329

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fix notebook execution #329

merged 1 commit into from
Dec 14, 2023

Conversation

Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Dec 14, 2023

Changes

  • Installs RavenPy using the ReadTheDocs Python block

Discussion

Currently, the Jupyter (non-MyST) notebooks are not run (nbsphinx is not in the extensions. Is the plan to prgressively move these over to the MyST standard ?

@Zeitsperre Zeitsperre self-assigned this Dec 14, 2023
@Zeitsperre Zeitsperre added the documentation Improvements or additions to documentation label Dec 14, 2023
@Zeitsperre Zeitsperre marked this pull request as ready for review December 14, 2023 20:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7214093863

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 81.316%

Files with Coverage Reduction New Missed Lines %
ravenpy/config/parsers.py 1 74.67%
ravenpy/ravenpy.py 3 86.39%
Totals Coverage Status
Change from base Build 7187507871: -0.1%
Covered Lines: 3325
Relevant Lines: 4089

💛 - Coveralls

@huard
Copy link
Collaborator

huard commented Dec 14, 2023

Some of the nb are compute intensive, so not clear.

@huard
Copy link
Collaborator

huard commented Dec 14, 2023

Merci !

@huard huard merged commit 9f80bb3 into master Dec 14, 2023
16 checks passed
@huard huard deleted the fix-nb branch December 14, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants